Repository navigation
CURA-13359 Fix fractional tree support overlapping regular support - #2402
Open
Erwan MATHIEU (wawanbreton) wants to merge 2 commits into
Open
Erwan MATHIEU (wawanbreton) wants to merge 2 commits into
Erwan MATHIEU (wawanbreton) wants to merge 2 commits into
Conversation
Erwan MATHIEU (wawanbreton)
marked this pull request as ready for review
October 9, 2026 13:11
Copilot started reviewing on behalf of
Erwan MATHIEU (wawanbreton)
October 9, 2026 13:11
View session
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Fractional support can still overlap regular support persisted by earlier mesh groups.
1 open finding
What changed in this PR
Separates fractional tree support from regular support to prevent overlapping extrusion.
Changes:
- Subtracts fractional support from regular support areas.
- Marks read-only support inputs as
const.
| File | Description |
|---|---|
src/TreeSupport.cpp |
Partitions fractional and regular support geometry. |
include/TreeSupport.h |
Updates parameter constness. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Remco Burema (rburema)
approved these changes
Oct 13, 2026
Remco Burema (rburema)
left a comment
Remco Burema (rburema)
left a comment
Member
There was a problem hiding this comment.
A bit strange that it still prints multiple layers of fractional support on top of each other -- but the old solution did that also, and I think it can't hurt (might even help).
Looks good otherwise!
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fractional tree support is added separately from regular support, and sometimes they could actually overlap. Now we substract the fractional support from the regular support so that they are printed separately.
Given the tree support handling of the fractional layers, the result is sometimes a bit unexpected, but does make some sense:
CURA-13359